From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Andrey Misiurov <amisiurov@cloudlinux.com>
Cc: Alexander Aring <alex.aring@gmail.com>,
Stefan Schmidt <stefan@datenfreihafen.org>,
linux-wpan@vger.kernel.org, netdev@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ieee802154: keep the original error after a netns rollback
Date: Thu, 19 Nov 2026 21:52:57 +0100 [thread overview]
Message-ID: <875wxsczme.fsf@bootlin.com> (raw)
In-Reply-To: <20261119172413.2068073-1-amisiurov@cloudlinux.com> (Andrey Misiurov's message of "Thu, 19 Nov 2026 18:24:13 +0100")
Hello Andrey,
> +++ b/net/ieee802154/core.c
> @@ -222,6 +222,7 @@
> {
> struct wpan_dev *wpan_dev;
> int err = 0;
> + int ret;
>
> list_for_each_entry(wpan_dev, &rdev->wpan_dev_list, list) {
> if (!wpan_dev->netdev)
> @@ -249,6 +250,7 @@
> return 0;
>
> errout:
> + ret = err;
> /* failed -- clean up to old netns */
> net = wpan_phy_net(&rdev->wpan_phy);
>
> @@ -264,7 +266,7 @@
> wpan_dev->netdev->netns_immutable = true;
Shall we just shadow int err in this loop? the current implementation is
correct but is a bit strange (having ret and err next to each other).
> }
>
> - return err;
> + return ret;
> }
>
> void cfg802154_dev_free(struct cfg802154_registered_device *rdev)
Thanks,
Miquèl
prev parent reply other threads:[~2026-11-19 20:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-19 17:24 Andrey Misiurov
2026-11-19 20:52 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875wxsczme.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=alex.aring@gmail.com \
--cc=amisiurov@cloudlinux.com \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefan@datenfreihafen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®