* [PATCH net] ieee802154: keep the original error after a netns rollback
@ 2026-11-19 17:24 Andrey Misiurov
2026-11-19 20:52 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Misiurov @ 2026-11-19 17:24 UTC (permalink / raw)
To: Alexander Aring, Stefan Schmidt, Miquel Raynal
Cc: linux-wpan, netdev, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Simon Horman, linux-kernel,
Andrey Misiurov
cfg802154_switch_netns() moves all of a phy's netdevs into a new netns. If
one move fails, it jumps to the errout label and moves the already-moved
netdevs back to the old netns.
That rollback loop overwrites the same 'err' variable with the result of
each move-back. The move-backs succeed, so 'err' ends up 0 and the function
returns 0 -- success -- even though nothing moved and the phy stayed in the
old netns. nl802154_wpan_phy_netns() then tells userspace the move worked.
Keep the original error in a separate variable and return that.
Fixes: 66e5c2672cd1 ("ieee802154: add netns support")
Signed-off-by: Andrey Misiurov <amisiurov@cloudlinux.com>
---
Found during a backport review.
On debian13 6.12.88, "iwpan phy phy0 set netns name T" reported success
(returned 0) while phy0 and its wpan0 interface stayed in the original
namespace; internally the move had failed with -EEXIST, but the function
returned 0 anyway. With the fix the same command correctly fails
with "File exists".
net/ieee802154/core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/ieee802154/core.c b/net/ieee802154/core.c
--- a/net/ieee802154/core.c
+++ b/net/ieee802154/core.c
@@ -222,6 +222,7 @@
{
struct wpan_dev *wpan_dev;
int err = 0;
+ int ret;
list_for_each_entry(wpan_dev, &rdev->wpan_dev_list, list) {
if (!wpan_dev->netdev)
@@ -249,6 +250,7 @@
return 0;
errout:
+ ret = err;
/* failed -- clean up to old netns */
net = wpan_phy_net(&rdev->wpan_phy);
@@ -264,7 +266,7 @@
wpan_dev->netdev->netns_immutable = true;
}
- return err;
+ return ret;
}
void cfg802154_dev_free(struct cfg802154_registered_device *rdev)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net] ieee802154: keep the original error after a netns rollback
2026-11-19 17:24 [PATCH net] ieee802154: keep the original error after a netns rollback Andrey Misiurov
@ 2026-11-19 20:52 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2026-11-19 20:52 UTC (permalink / raw)
To: Andrey Misiurov
Cc: Alexander Aring, Stefan Schmidt, linux-wpan, netdev,
David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Simon Horman, linux-kernel
Hello Andrey,
> +++ b/net/ieee802154/core.c
> @@ -222,6 +222,7 @@
> {
> struct wpan_dev *wpan_dev;
> int err = 0;
> + int ret;
>
> list_for_each_entry(wpan_dev, &rdev->wpan_dev_list, list) {
> if (!wpan_dev->netdev)
> @@ -249,6 +250,7 @@
> return 0;
>
> errout:
> + ret = err;
> /* failed -- clean up to old netns */
> net = wpan_phy_net(&rdev->wpan_phy);
>
> @@ -264,7 +266,7 @@
> wpan_dev->netdev->netns_immutable = true;
Shall we just shadow int err in this loop? the current implementation is
correct but is a bit strange (having ret and err next to each other).
> }
>
> - return err;
> + return ret;
> }
>
> void cfg802154_dev_free(struct cfg802154_registered_device *rdev)
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-11-19 20:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 17:24 [PATCH net] ieee802154: keep the original error after a netns rollback Andrey Misiurov
2026-11-19 20:52 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®