* [PATCH v2 linux-next] mtd: block2mtd: check device size
@ 2014-03-06 10:04 Fabian Frederick
2014-03-09 4:50 ` Brian Norris
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-03-06 10:04 UTC (permalink / raw)
To: linux-kernel; +Cc: computersforpeace, ezequiel.garcia
fixme applied : check device size is a multiple of erasesize.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/mtd/devices/block2mtd.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
index 3e12234..66f0405 100644
--- a/drivers/mtd/devices/block2mtd.c
+++ b/drivers/mtd/devices/block2mtd.c
@@ -209,7 +209,6 @@ static void block2mtd_free_device(struct block2mtd_dev *dev)
}
-/* FIXME: ensure that mtd->size % erase_size == 0 */
static struct block2mtd_dev *add_device(char *devname, int erase_size)
{
const fmode_t mode = FMODE_READ | FMODE_WRITE | FMODE_EXCL;
@@ -249,6 +248,11 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
goto err_free_block2mtd;
}
+ if ((long)dev->blkdev->bd_inode->i_size % erase_size) {
+ pr_err("erasesize must be a divisor of device size\n");
+ goto err_free_block2mtd;
+ }
+
mutex_init(&dev->write_mutex);
/* Setup the MTD structure */
--
1.8.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2 linux-next] mtd: block2mtd: check device size
2014-03-06 10:04 [PATCH v2 linux-next] mtd: block2mtd: check device size Fabian Frederick
@ 2014-03-09 4:50 ` Brian Norris
0 siblings, 0 replies; 2+ messages in thread
From: Brian Norris @ 2014-03-09 4:50 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, ezequiel.garcia
On Thu, Mar 6, 2014 at 2:04 AM, Fabian Frederick <fabf@skynet.be> wrote:
> fixme applied : check device size is a multiple of erasesize.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Pushed to l2-mtd.git. Thanks!
Brian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-09 4:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-06 10:04 [PATCH v2 linux-next] mtd: block2mtd: check device size Fabian Frederick
2014-03-09 4:50 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®