mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Tobias Schumacher" <ts@linux.ibm.com>
To: "Niklas Schnelle" <schnelle@linux.ibm.com>,
	"Tobias Schumacher" <ts@linux.ibm.com>,
	"Gerd Bayer" <gbayer@linux.ibm.com>,
	"Julian Ruess" <julianr@linux.ibm.com>,
	"Farhan Ali" <alifm@linux.ibm.com>,
	"Christian Borntraeger" <borntraeger@linux.ibm.com>,
	"Halil Pasic" <pasic@linux.ibm.com>,
	"Matthew Rosato" <mjrosato@linux.ibm.com>
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
	"Vasily Gorbik" <gor@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	"Sven Schnelle" <svens@linux.ibm.com>,
	<linux-s390@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/7] s390/pci: Add error cleanup in zpci_directed_irq_init
Date: Wed, 07 Oct 2026 08:10:12 +0200	[thread overview]
Message-ID: <DLYDSD0HXOAO.1Y1H1RMHUNSDG@linux.ibm.com> (raw)
In-Reply-To: <f5817b10564942c8a3e1ee309b21ec0bdb803e97.camel@linux.ibm.com>

On Tue Oct 6, 2026 at 9:19 PM CEST, Niklas Schnelle wrote:
> On Mon, 2026-10-05 at 14:03 +0200, Tobias Schumacher wrote:
>> If per-CPU airq_iv allocation fails in the loop, previously allocated
>> vectors and arrays leak. Add proper error path to release all resources
>> on failure.
>>
>> Fixes: e979ce7bced2 ("s390/pci: provide support for CPU directed interrupts")
>> Signed-off-by: Tobias Schumacher <ts@linux.ibm.com>
>
> Had my bot review my reviews and it noticed that this is missing Cc
> stable despite having a Fixes tag.

Yes, this was intentional. The leak only happens if an allocation fails
during boot, which would make PCI unusable anyway, so I didn't think it
qualifies for stable. But I wouldn't mind adding Cc: stable if you
prefer.

Thanks,
Tobias

  reply	other threads:[~2026-10-07  6:10 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 12:03 [PATCH v2 0/7] s390/pci: Fix bugs in IRQ domain migration and resource cleanup Tobias Schumacher
2026-10-05 12:03 ` [PATCH v2 1/7] s390/pci: Fix double-free and NULL deref in zpci MSI domain cleanup Tobias Schumacher
2026-10-06  9:42   ` Niklas Schnelle
2026-10-05 12:03 ` [PATCH v2 2/7] s390/pci: Fix resource leak in zpci MSI setup Tobias Schumacher
2026-10-06  9:55   ` Niklas Schnelle
2026-10-05 12:03 ` [PATCH v2 3/7] s390/pci: Fix MSI directed-mode teardown IRQ bit count Tobias Schumacher
2026-10-06 11:10   ` Niklas Schnelle
2026-10-05 12:03 ` [PATCH v2 4/7] s390/pci: Fix use-after-free race in zpci floating interrupt cleanup Tobias Schumacher
2026-10-06 15:18   ` Niklas Schnelle
2026-10-07  5:50     ` Tobias Schumacher
2026-10-06 19:23   ` Niklas Schnelle
2026-10-07  6:02     ` Tobias Schumacher
2026-10-05 12:03 ` [PATCH v2 5/7] s390/pci: Add error cleanup in zpci_directed_irq_init Tobias Schumacher
2026-10-06 13:32   ` Niklas Schnelle
2026-10-07  6:04     ` Tobias Schumacher
2026-10-06 19:19   ` Niklas Schnelle
2026-10-07  6:10     ` Tobias Schumacher [this message]
2026-10-05 12:03 ` [PATCH v2 6/7] s390/pci: Set MSI_FLAG_NO_AFFINITY at IRQ init time Tobias Schumacher
2026-10-06 15:33   ` Niklas Schnelle
2026-10-05 12:03 ` [PATCH v2 7/7] s390/pci: Drop the unused index argument of zpci_msi_clear_airq() Tobias Schumacher
2026-10-06 15:28   ` Niklas Schnelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLYDSD0HXOAO.1Y1H1RMHUNSDG@linux.ibm.com \
    --to=ts@linux.ibm.com \
    --cc=agordeev@linux.ibm.com \
    --cc=alifm@linux.ibm.com \
    --cc=borntraeger@linux.ibm.com \
    --cc=gbayer@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=julianr@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mjrosato@linux.ibm.com \
    --cc=pasic@linux.ibm.com \
    --cc=schnelle@linux.ibm.com \
    --cc=svens@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®