Re: [PATCH 4.19 07/29] ext4: dont remount read-only with errors=continue on reboot

Re: [PATCH 4.19 07/29] ext4: dont remount read-only with errors=continue on reboot

[greg]

On Thu, Jan 07, 2021 at 11:39:14AM +0000, Partha Nayak wrote:
> Hi Greg / Linux community
> 
> I was going through the patch details: https://www.spinics.net/lists/stable/msg436529.html .
> 
> In our case the superblock for EXT4 is configured to trigger a kernel panic . But inspite of that the file system was mounted as read-only . We are on 4.19.12 .

4.19.12 is _VERY_ old and obsolete and totally insecure and is not
supported by the community, it was released over two years ago.

Why not apply the patch you link here and see if it solves your issue?

Or, better yet, move to 4.19.165, or 5.10.y?  What prevents you from
doing that?

good luck!

greg k-h

[PATCH 4.19 00/29] 4.19.165-rc2 review

[Greg Kroah-Hartman]

This is the start of the stable review cycle for the 4.19.165 release.
There are 29 patches in this series, all will be posted as a response
to this one.  If anyone has any issues with these being applied, please
let me know.

Responses should be made by Thu, 07 Jan 2021 09:08:03 +0000.
Anything received after that time might be too late.

The whole patch series can be found in one patch at:
	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-4.19.165-rc2.gz
or in the git tree and branch at:
	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.19.y
and the diffstat can be found below.

thanks,

greg k-h

-------------
Pseudo-Shortlog of commits:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Linux 4.19.165-rc2

Hyeongseok Kim <hyeongseok@gmail.com>
    dm verity: skip verity work if I/O error when system is shutting down

Takashi Iwai <tiwai@suse.de>
    ALSA: pcm: Clear the full allocated memory at hw_params

Jessica Yu <jeyu@kernel.org>
    module: delay kobject uevent until after module init call

Trond Myklebust <trond.myklebust@hammerspace.com>
    NFSv4: Fix a pNFS layout related use-after-free race when freeing the inode

Qinglang Miao <miaoqinglang@huawei.com>
    powerpc: sysdev: add missing iounmap() on error in mpic_msgr_probe()

Jan Kara <jack@suse.cz>
    quota: Don't overflow quota file offsets

Miroslav Benes <mbenes@suse.cz>
    module: set MODULE_STATE_GOING state when a module fails to load

Dinghao Liu <dinghao.liu@zju.edu.cn>
    rtc: sun6i: Fix memleak in sun6i_rtc_clk_init

Boqun Feng <boqun.feng@gmail.com>
    fcntl: Fix potential deadlock in send_sig{io, urg}()

Takashi Iwai <tiwai@suse.de>
    ALSA: rawmidi: Access runtime->avail always in spinlock

Takashi Iwai <tiwai@suse.de>
    ALSA: seq: Use bool for snd_seq_queue internal flags

Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
    media: gp8psk: initialize stats at power control logic

Anant Thazhemadam <anant.thazhemadam@gmail.com>
    misc: vmw_vmci: fix kernel info-leak by initializing dbells in vmci_ctx_get_chkpt_doorbells()

Rustam Kovhaev <rkovhaev@gmail.com>
    reiserfs: add check for an invalid ih_entry_count

Anant Thazhemadam <anant.thazhemadam@gmail.com>
    Bluetooth: hci_h5: close serdev device and free hu in h5_close

Johan Hovold <johan@kernel.org>
    of: fix linker-section match-table corruption

Damien Le Moal <damien.lemoal@wdc.com>
    null_blk: Fix zone size initialization

Souptick Joarder <jrdr.linux@gmail.com>
    xen/gntdev.c: Mark pages as dirty

Christophe Leroy <christophe.leroy@csgroup.eu>
    powerpc/bitops: Fix possible undefined behaviour with fls() and fls64()

Paolo Bonzini <pbonzini@redhat.com>
    KVM: x86: reinstate vendor-agnostic check on SPEC_CTRL cpuid bits

Paolo Bonzini <pbonzini@redhat.com>
    KVM: SVM: relax conditions for allowing MSR_IA32_SPEC_CTRL accesses

Petr Vorel <petr.vorel@gmail.com>
    uapi: move constants from <linux/kernel.h> to <linux/const.h>

Jan Kara <jack@suse.cz>
    ext4: don't remount read-only with errors=continue on reboot

Eric Auger <eric.auger@redhat.com>
    vfio/pci: Move dummy_resources_list init in vfio_pci_probe()

Eric Biggers <ebiggers@google.com>
    ubifs: prevent creating duplicate encrypted filenames

Eric Biggers <ebiggers@google.com>
    f2fs: prevent creating duplicate encrypted filenames

Eric Biggers <ebiggers@google.com>
    ext4: prevent creating duplicate encrypted filenames

Eric Biggers <ebiggers@google.com>
    fscrypt: add fscrypt_is_nokey_name()

Kevin Vigor <kvigor@gmail.com>
    md/raid10: initialize r10_bio->read_slot before use.


-------------

Diffstat:

 Makefile                                |  4 +--
 arch/powerpc/include/asm/bitops.h       | 23 ++++++++++++++--
 arch/powerpc/sysdev/mpic_msgr.c         |  2 +-
 arch/x86/kvm/cpuid.h                    | 14 ++++++++++
 arch/x86/kvm/svm.c                      |  9 ++----
 arch/x86/kvm/vmx.c                      |  6 ++--
 drivers/block/null_blk_zoned.c          | 20 +++++++++-----
 drivers/bluetooth/hci_h5.c              |  8 ++++--
 drivers/md/dm-verity-target.c           | 12 +++++++-
 drivers/md/raid10.c                     |  3 +-
 drivers/media/usb/dvb-usb/gp8psk.c      |  2 +-
 drivers/misc/vmw_vmci/vmci_context.c    |  2 +-
 drivers/rtc/rtc-sun6i.c                 |  8 ++++--
 drivers/vfio/pci/vfio_pci.c             |  3 +-
 drivers/xen/gntdev.c                    | 17 ++++++++----
 fs/crypto/hooks.c                       | 10 +++----
 fs/ext4/namei.c                         |  3 ++
 fs/ext4/super.c                         | 14 ++++------
 fs/f2fs/f2fs.h                          |  2 ++
 fs/fcntl.c                              | 10 ++++---
 fs/nfs/nfs4super.c                      |  2 +-
 fs/nfs/pnfs.c                           | 33 ++++++++++++++++++++--
 fs/nfs/pnfs.h                           |  5 ++++
 fs/quota/quota_tree.c                   |  8 +++---
 fs/reiserfs/stree.c                     |  6 ++++
 fs/ubifs/dir.c                          | 17 +++++++++---
 include/linux/fscrypt_notsupp.h         |  5 ++++
 include/linux/fscrypt_supp.h            | 29 +++++++++++++++++++
 include/linux/of.h                      |  1 +
 include/uapi/linux/const.h              |  5 ++++
 include/uapi/linux/ethtool.h            |  2 +-
 include/uapi/linux/kernel.h             |  9 +-----
 include/uapi/linux/lightnvm.h           |  2 +-
 include/uapi/linux/mroute6.h            |  2 +-
 include/uapi/linux/netfilter/x_tables.h |  2 +-
 include/uapi/linux/netlink.h            |  2 +-
 include/uapi/linux/sysctl.h             |  2 +-
 kernel/module.c                         |  6 ++--
 sound/core/pcm_native.c                 |  9 ++++--
 sound/core/rawmidi.c                    | 49 +++++++++++++++++++++++----------
 sound/core/seq/seq_queue.h              |  8 +++---
 41 files changed, 275 insertions(+), 101 deletions(-)

[PATCH 4.19 07/29] ext4: dont remount read-only with errors=continue on reboot

[Greg Kroah-Hartman]

From: Jan Kara <jack@suse.cz>

[ Upstream commit b08070eca9e247f60ab39d79b2c25d274750441f ]

ext4_handle_error() with errors=continue mount option can accidentally
remount the filesystem read-only when the system is rebooting. Fix that.

Fixes: 1dc1097ff60e ("ext4: avoid panic during forced reboot")
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Cc: stable@kernel.org
Link: https://lore.kernel.org/r/20201127113405.26867-2-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 fs/ext4/super.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index ee96f504ed782..e9e9f09f5370d 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -454,19 +454,17 @@ static bool system_going_down(void)
 
 static void ext4_handle_error(struct super_block *sb)
 {
+	journal_t *journal = EXT4_SB(sb)->s_journal;
+
 	if (test_opt(sb, WARN_ON_ERROR))
 		WARN_ON_ONCE(1);
 
-	if (sb_rdonly(sb))
+	if (sb_rdonly(sb) || test_opt(sb, ERRORS_CONT))
 		return;
 
-	if (!test_opt(sb, ERRORS_CONT)) {
-		journal_t *journal = EXT4_SB(sb)->s_journal;
-
-		EXT4_SB(sb)->s_mount_flags |= EXT4_MF_FS_ABORTED;
-		if (journal)
-			jbd2_journal_abort(journal, -EIO);
-	}
+	EXT4_SB(sb)->s_mount_flags |= EXT4_MF_FS_ABORTED;
+	if (journal)
+		jbd2_journal_abort(journal, -EIO);
 	/*
 	 * We force ERRORS_RO behavior when system is rebooting. Otherwise we
 	 * could panic during 'reboot -f' as the underlying device got already
-- 
2.27.0