[PATCH] clk: qcom: mmcc-msm8996: Fix FD AHB clock register offset

[PATCH] clk: qcom: mmcc-msm8996: Fix FD AHB clock register offset

[Abel Vesa]

The FD AHB clock branch register is at offset 0x3b74, not 0x3ba74.
The incorrect offset exceeds the regmap maximum of 0xb008, so regmap
rejects accesses to it and the clock cannot be enabled.

Correct both the enable and halt register offsets so the driver can
enable the branch and check its status.

Assisted-by: LLM
Fixes: c252659770db ("clk: qcom: Add MSM8996 Multimedia Clock Controller (MMCC) driver")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 drivers/clk/qcom/mmcc-msm8996.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/mmcc-msm8996.c b/drivers/clk/qcom/mmcc-msm8996.c
index 3426e3dde924..ef7bde361fc3 100644
--- a/drivers/clk/qcom/mmcc-msm8996.c
+++ b/drivers/clk/qcom/mmcc-msm8996.c
@@ -3133,9 +3133,9 @@ static struct clk_branch fd_core_uar_clk = {
 };
 
 static struct clk_branch fd_ahb_clk = {
-	.halt_reg = 0x3ba74,
+	.halt_reg = 0x3b74,
 	.clkr = {
-		.enable_reg = 0x3ba74,
+		.enable_reg = 0x3b74,
 		.enable_mask = BIT(0),
 		.hw.init = &(struct clk_init_data){
 			.name = "fd_ahb_clk",

---
base-commit: e6e35979777d646fe3c7c94dca7dd32fb25d45f4
change-id: 20260916-clk-qcom-mmcc-msm8996-fix-fd-ahb-offset-c7bbc8d29f6a

Best regards,
--  
Abel Vesa <abel.vesa@oss.qualcomm.com>

Re: [PATCH] clk: qcom: mmcc-msm8996: Fix FD AHB clock register offset

[Konrad Dybcio]

On 9/16/26 1:45 PM, Abel Vesa wrote:
> The FD AHB clock branch register is at offset 0x3b74, not 0x3ba74.
> The incorrect offset exceeds the regmap maximum of 0xb008, so regmap
> rejects accesses to it and the clock cannot be enabled.
> 
> Correct both the enable and halt register offsets so the driver can
> enable the branch and check its status.
> 
> Assisted-by: LLM
> Fixes: c252659770db ("clk: qcom: Add MSM8996 Multimedia Clock Controller (MMCC) driver")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH] clk: qcom: mmcc-msm8996: Fix FD AHB clock register offset

[Bjorn Andersson]

On Wed, 16 Sep 2026 14:45:53 +0300, Abel Vesa wrote:
> The FD AHB clock branch register is at offset 0x3b74, not 0x3ba74.
> The incorrect offset exceeds the regmap maximum of 0xb008, so regmap
> rejects accesses to it and the clock cannot be enabled.
> 
> Correct both the enable and halt register offsets so the driver can
> enable the branch and check its status.
> 
> [...]

Applied, thanks!

[1/1] clk: qcom: mmcc-msm8996: Fix FD AHB clock register offset
      commit: 3c8abc5a814a0349912d59a91ed7c459475758ce

Best regards,
-- 
Bjorn Andersson <andersson@kernel.org>