From: Li Zhijian <lizhijian@cn.fujitsu.com>
To: <linux-kernel@vger.kernel.org>, <peterz@infradead.org>,
<mingo@redhat.com>, <acme@kernel.org>,
<alexander.shishkin@linux.intel.com>, <kim.phillips@arm.com>
Cc: <philip.li@intel.com>
Subject: Re: [PATCH] perf test shell: trace+probe_libc_inet_pton.sh: force to use /bin/bash to load this script
Date: Thu, 19 Oct 2017 13:10:46 +0800 [thread overview]
Message-ID: <dbe5e8b5-a823-e6ee-47fc-5dfb0b1ae6c5@cn.fujitsu.com> (raw)
In-Reply-To: <1508385233-30676-1-git-send-email-lizhijian@cn.fujitsu.com>
ignore this patch please, it will broken the test description which is read from the first line of this script
Thanks
On 10/19/2017 11:53 AM, Li Zhijian wrote:
> this script contains Array, but not all sh support Array. by default, dash provides sh at ubuntu/debian
> which can not support Array. so force to use /bin/bash
>
> it can fix following issue:
> lizhijian@localhost:~/lkp/linux/tools/perf/tests/shell$ sudo ./trace+probe_libc_inet_pton.sh
> [sudo] password for lizhijian: PING ::1(::1) 56 data bytes
> ./trace+probe_libc_inet_pton.sh: 30: ./trace+probe_libc_inet_pton.sh: Bad substitution
> ./trace+probe_libc_inet_pton.sh: 32: ./trace+probe_libc_inet_pton.sh: Bad substitution
>
> Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
> ---
> tools/perf/tests/shell/trace+probe_libc_inet_pton.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh b/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh
> index 7a84d73..df04cc1 100755
> --- a/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh
> +++ b/tools/perf/tests/shell/trace+probe_libc_inet_pton.sh
> @@ -1,3 +1,5 @@
> +#!/bin/bash
> +
> # probe libc's inet_pton & backtrace it with ping
>
> # Installs a probe on libc's inet_pton function, that will use uprobes,
prev parent reply other threads:[~2017-10-19 5:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 3:53 Li Zhijian
2017-10-19 5:10 ` Li Zhijian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbe5e8b5-a823-e6ee-47fc-5dfb0b1ae6c5@cn.fujitsu.com \
--to=lizhijian@cn.fujitsu.com \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=kim.phillips@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=philip.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®