From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Rob Clark <robin.clark@oss.qualcomm.com>,
Dmitry Baryshkov <lumag@kernel.org>,
Abhinav Kumar <abhinav.kumar@linux.dev>,
Jessica Zhang <jesszhan0024@gmail.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
Yongxing Mou <yongxing.mou@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 03/10] drm/msm/dp: Read DPCD and sink count in bridge detect()
Date: Fri, 22 May 2026 16:41:11 +0200 [thread overview]
Message-ID: <f1d191cd-22a7-415d-8ab7-9c0948b9e30a@oss.qualcomm.com> (raw)
In-Reply-To: <q3wtsw3djk47izq7za5p425wuxoykfsejpm5hs72jtbytnrgpn@in2o4iza7svk>
On 5/22/26 4:38 PM, Dmitry Baryshkov wrote:
> On Fri, May 22, 2026 at 01:30:54PM +0200, Konrad Dybcio wrote:
>> On 3/14/26 2:09 AM, Dmitry Baryshkov wrote:
>>> From: Jessica Zhang <jesszhan0024@gmail.com>
>>>
>>> Instead of relying on the link_ready flag to specify if DP is connected,
>>> read the DPCD bits and get the sink count to accurately detect if DP is
>>> connected.
>>>
>>> Signed-off-by: Jessica Zhang <jessica.zhang@oss.qualcomm.com>
>>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>>> ---
>>
>> There's still some trailing style/documentation feedback here from v3
>
> I'll correct most of the feedback from both you and Bjorn. I'll leave pm
> calls as is, without using ACQUIRE macros. I will think about using them
> for the whole driver rather than just a single function.
Sounds good
Konrad
next prev parent reply other threads:[~2026-05-22 14:41 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 1:09 [PATCH v5 00/10] drm/msm/dp: Drop the HPD state machine Dmitry Baryshkov
2026-03-14 1:09 ` [PATCH v5 01/10] drm/msm/dp: fix HPD state status bit shift value Dmitry Baryshkov
2026-05-22 11:28 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 02/10] drm/msm/dp: Fix the ISR_* enum values Dmitry Baryshkov
2026-05-22 11:28 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 03/10] drm/msm/dp: Read DPCD and sink count in bridge detect() Dmitry Baryshkov
2026-05-22 11:30 ` Konrad Dybcio
2026-05-22 14:38 ` Dmitry Baryshkov
2026-05-22 14:41 ` Konrad Dybcio [this message]
2026-03-14 1:09 ` [PATCH v5 04/10] drm/msm/dp: Move link training to atomic_enable() Dmitry Baryshkov
2026-05-22 11:33 ` Konrad Dybcio
2026-05-24 9:51 ` Dmitry Baryshkov
2026-05-22 11:33 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 05/10] drm/msm/dp: Drop EV_USER_NOTIFICATION Dmitry Baryshkov
2026-05-22 11:35 ` Konrad Dybcio
2026-05-22 11:35 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 06/10] drm/msm/dp: drop event data Dmitry Baryshkov
2026-05-22 11:36 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 07/10] drm/msm/dp: rework HPD handling Dmitry Baryshkov
2026-03-14 1:09 ` [PATCH v5 08/10] drm/msm/dp: Add sink_count to debug logs Dmitry Baryshkov
2026-05-22 11:40 ` Konrad Dybcio
2026-05-24 9:57 ` Dmitry Baryshkov
2026-03-14 1:09 ` [PATCH v5 09/10] drm/msm/dp: turn link_ready into plugged Dmitry Baryshkov
2026-05-22 11:47 ` Konrad Dybcio
2026-03-14 1:09 ` [PATCH v5 10/10] drm/msm/dp: clear EDID on display unplug Dmitry Baryshkov
2026-05-22 11:49 ` Konrad Dybcio
2026-05-22 12:02 ` Dmitry Baryshkov
2026-05-22 12:06 ` Konrad Dybcio
2026-03-15 0:51 ` [PATCH v5 00/10] drm/msm/dp: Drop the HPD state machine Val Packett
2026-03-15 1:10 ` Val Packett
2026-03-16 3:23 ` Dmitry Baryshkov
2026-03-17 23:15 ` Val Packett
2026-03-18 1:03 ` Dmitry Baryshkov
2026-03-18 1:58 ` Val Packett
2026-05-22 11:27 ` Konrad Dybcio
2026-05-19 6:25 ` Yongxing Mou
2026-05-20 16:14 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1d191cd-22a7-415d-8ab7-9c0948b9e30a@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=abhinav.kumar@linux.dev \
--cc=airlied@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jesszhan0024@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=quic_khsieh@quicinc.com \
--cc=robin.clark@oss.qualcomm.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=yongxing.mou@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®