From: Andrew Lunn <andrew@lunn.ch>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
netdev-bot+sinfo@kernel.org, netdev@vger.kernel.org,
Paolo Abeni <pabeni@redhat.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Serge Semin <fancer.lancer@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Nicolai Buchwitz <nb@tipi-net.de>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: stmmac: unwind the WoL IRQ after a safety IRQ request failure
Date: Wed, 7 Oct 2026 14:46:23 +0200 [thread overview]
Message-ID: <f304ee6d-bbc2-4f76-964a-998c3febb8dc@lunn.ch> (raw)
In-Reply-To: <CADvTj4pm8fbgGDiyXVHubnM93qOey7o18O+MDU68MSisXVvHtw@mail.gmail.com>
On Tue, Oct 06, 2026 at 07:27:05PM -0600, James Hilliard wrote:
> On Tue, Oct 6, 2026 at 6:57 PM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Tue, Oct 06, 2026 at 05:17:20PM -0600, James Hilliard wrote:
> > > On Tue, Oct 6, 2026 at 4:52 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > > >
> > > > On Tue, 6 Oct 2026 01:14:52 -0600 James Hilliard wrote:
> > > > > > Please do not repost the series just to address the above. Instead,
> > > > > > reply to this email with the missing information, so that reviewers
> > > > > > can take it into account. If the series needs another revision for
> > > > > > other reasons, please include the information in the commit messages
> > > > > > then.
> > > >
> > > > Please make sure you read this paragraph, to the end.
> > >
> > > How much detail should I be including?
> >
> > We want to decide should the patch go to net, because it is a real
> > problem which bothers somebody. Or is it a theoretical problem which
> > will never happen, so we might want net-next, or maybe /dev/null.
>
> I mean, it's in an error handling pathway that could be hit if there's
> an -ENOMEM error on an IRQ-action allocation.
ENOMEM does not happen for small allocations.
https://lwn.net/Articles/627419/
So at first glance, this seems totally theoretical, it will never
happen. So net-next, no need for a Fixes tag, etc.
Andrew
next prev parent reply other threads:[~2026-10-07 12:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 7:06 James Hilliard
2026-10-06 7:09 ` netdev-bot+sinfo
2026-10-06 7:14 ` James Hilliard
2026-10-06 22:52 ` Jakub Kicinski
2026-10-06 23:17 ` James Hilliard
2026-10-07 0:57 ` Andrew Lunn
2026-10-07 1:27 ` James Hilliard
2026-10-07 12:46 ` Andrew Lunn [this message]
2026-10-07 17:00 ` James Hilliard
2026-10-07 18:32 ` Andrew Lunn
2026-10-07 19:31 ` James Hilliard
2026-10-07 19:34 ` Andrew Lunn
2026-10-07 1:10 ` Jakub Kicinski
2026-10-06 7:50 ` Maxime Chevallier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f304ee6d-bbc2-4f76-964a-998c3febb8dc@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=james.hilliard1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=nb@tipi-net.de \
--cc=netdev-bot+sinfo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®