* [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt
@ 2017-06-05 17:29 Colin King
2017-06-07 22:42 ` Madhani, Himanshu
2017-06-13 1:12 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2017-06-05 17:29 UTC (permalink / raw)
To: qla2xxx-upstream, James E . J . Bottomley, Martin K . Petersen,
linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove
redundant wait when target is stopped.") removed a null check
on ha->tgt.tgt_ops and replaced it with a new check that null
checked tgt, thus making the subsequent null check on tgt
totally redundant. Remove it.
Detected by CoverityScan, CID#1440452 ("Logically Dead Code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/qla2xxx/qla_target.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
index cb33ca87ca37..3594a76f6155 100644
--- a/drivers/scsi/qla2xxx/qla_target.c
+++ b/drivers/scsi/qla2xxx/qla_target.c
@@ -5519,12 +5519,6 @@ void qlt_async_event(uint16_t code, struct scsi_qla_host *vha,
if (!tgt || tgt->tgt_stop || tgt->tgt_stopped)
return;
- if (unlikely(tgt == NULL)) {
- ql_dbg(ql_dbg_tgt, vha, 0xe03a,
- "ASYNC EVENT %#x, but no tgt (ha %p)\n", code, ha);
- return;
- }
-
if (((code == MBA_POINT_TO_POINT) || (code == MBA_CHG_IN_CONNECTION)) &&
IS_QLA2100(ha))
return;
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt
2017-06-05 17:29 [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt Colin King
@ 2017-06-07 22:42 ` Madhani, Himanshu
2017-06-13 1:12 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Madhani, Himanshu @ 2017-06-07 22:42 UTC (permalink / raw)
To: Colin King
Cc: Dept-Eng QLA2xxx Upstream, James E . J . Bottomley,
Martin K . Petersen, linux-scsi, kernel-janitors, linux-kernel
> On Jun 5, 2017, at 10:29 AM, Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove
> redundant wait when target is stopped.") removed a null check
> on ha->tgt.tgt_ops and replaced it with a new check that null
> checked tgt, thus making the subsequent null check on tgt
> totally redundant. Remove it.
>
> Detected by CoverityScan, CID#1440452 ("Logically Dead Code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/scsi/qla2xxx/qla_target.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c
> index cb33ca87ca37..3594a76f6155 100644
> --- a/drivers/scsi/qla2xxx/qla_target.c
> +++ b/drivers/scsi/qla2xxx/qla_target.c
> @@ -5519,12 +5519,6 @@ void qlt_async_event(uint16_t code, struct scsi_qla_host *vha,
> if (!tgt || tgt->tgt_stop || tgt->tgt_stopped)
> return;
>
> - if (unlikely(tgt == NULL)) {
> - ql_dbg(ql_dbg_tgt, vha, 0xe03a,
> - "ASYNC EVENT %#x, but no tgt (ha %p)\n", code, ha);
> - return;
> - }
> -
> if (((code == MBA_POINT_TO_POINT) || (code == MBA_CHG_IN_CONNECTION)) &&
> IS_QLA2100(ha))
> return;
> --
> 2.11.0
>
Looks good.
Acked-by: Himanshu Madhani <himanshu.madhani@cavium.com>
Thanks,
- Himanshu
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt
2017-06-05 17:29 [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt Colin King
2017-06-07 22:42 ` Madhani, Himanshu
@ 2017-06-13 1:12 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-06-13 1:12 UTC (permalink / raw)
To: Colin King
Cc: qla2xxx-upstream, James E . J . Bottomley, Martin K . Petersen,
linux-scsi, kernel-janitors, linux-kernel
Colin,
> An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove redundant
> wait when target is stopped.") removed a null check on ha->tgt.tgt_ops
> and replaced it with a new check that null checked tgt, thus making
> the subsequent null check on tgt totally redundant. Remove it.
Applied to 4.13/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-13 1:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-05 17:29 [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt Colin King
2017-06-07 22:42 ` Madhani, Himanshu
2017-06-13 1:12 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®